Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 29 Feb 2024 10:24:33 +0100 | Subject | Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED |
| |
Hi Chris,
On Wed, Feb 28, 2024 at 9:02 PM Chris Packham <Chris.Packham@alliedtelesis.co.nz> wrote: > On 29/02/24 03:04, Rob Herring wrote: > > On Wed, Feb 28, 2024 at 10:22:42AM +1300, Chris Packham wrote: > >> + segment-gpios: > >> + description: > >> + An array of GPIOs one per segment. > >> + minItems: 7 > > How does one know which GPIO is which segment? > > I've expanded the description in v3. > > + An array of GPIOs one per segment. The first GPIO corresponds to the A > + segment the last GPIO corresponds to the G segment. > > Do you think that's sufficient or do I need to add more? In the driver > itself I've put a little ascii art diagram of the segments.
Given users are reading the bindings rather than the driver source, I would move the diagram to the bindings.
Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |