lkml.org 
[lkml]   [2024]   [Feb]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v5 3/5] crypto: tegra: Add Tegra Security Engine driver
Date
> +
> +static int tegra_sha_export(struct ahash_request *req, void *out)
> +{
> + struct tegra_sha_reqctx *rctx = ahash_request_ctx(req);
> + struct crypto_ahash *tfm = crypto_ahash_reqtfm(req);
> + struct tegra_sha_ctx *ctx = crypto_ahash_ctx(tfm);
> + int i;
> +
> + if (ctx->fallback)
> + return tegra_sha_fallback_export(req, out);
> +
> + memcpy(out, rctx, sizeof(*rctx));
> +
> + return 0;
> +}
> +
> +static int tegra_sha_import(struct ahash_request *req, const void *in)
> +{
> + struct tegra_sha_reqctx *rctx = ahash_request_ctx(req);
> + struct crypto_ahash *tfm = crypto_ahash_reqtfm(req);
> + struct tegra_sha_ctx *ctx = crypto_ahash_ctx(tfm);
> + int i;
Got a warning from testbot for an unused variable here as well as in the export()
function. I will fix that in the next revision.

Do we have any other concerns with the driver currently, which I can address
in the next revision?

Regards,
Akhil


\
 
 \ /
  Last update: 2024-05-27 15:27    [W:0.083 / U:1.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site