Messages in this thread | | | From | Akhil R <> | Subject | RE: [PATCH v5 3/5] crypto: tegra: Add Tegra Security Engine driver | Date | Thu, 29 Feb 2024 09:20:48 +0000 |
| |
> + > +static int tegra_sha_export(struct ahash_request *req, void *out) > +{ > + struct tegra_sha_reqctx *rctx = ahash_request_ctx(req); > + struct crypto_ahash *tfm = crypto_ahash_reqtfm(req); > + struct tegra_sha_ctx *ctx = crypto_ahash_ctx(tfm); > + int i; > + > + if (ctx->fallback) > + return tegra_sha_fallback_export(req, out); > + > + memcpy(out, rctx, sizeof(*rctx)); > + > + return 0; > +} > + > +static int tegra_sha_import(struct ahash_request *req, const void *in) > +{ > + struct tegra_sha_reqctx *rctx = ahash_request_ctx(req); > + struct crypto_ahash *tfm = crypto_ahash_reqtfm(req); > + struct tegra_sha_ctx *ctx = crypto_ahash_ctx(tfm); > + int i; Got a warning from testbot for an unused variable here as well as in the export() function. I will fix that in the next revision.
Do we have any other concerns with the driver currently, which I can address in the next revision?
Regards, Akhil
| |