Messages in this thread | | | Subject | Re: [net-next PatchV3] octeontx2-pf: Add support to read eeprom information | From | Paolo Abeni <> | Date | Thu, 29 Feb 2024 10:14:17 +0100 |
| |
On Tue, 2024-02-27 at 16:47 +0100, Andrew Lunn wrote: > On Tue, Feb 27, 2024 at 02:17:22PM +0530, Hariprasad Kelam wrote: > > Add support to read/decode EEPROM module information using ethtool. > > Usage: ethtool -m <interface> > > > > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com> > > Signed-off-by: Sunil Goutham <sgoutham@marvell.com> > > --- > > V3 * remove redundant checks as stack is already doing it. > > So still only access to the first 256 bytes, using the old internal > API. > > Disappointing. > > And the Signed-of-by: appear to be in the wrong order.
To clarify: If Sunil is the author of this patch, you should put his SoB first and add a From: tag before the changelog, see:
https://elixir.bootlin.com/linux/v6.8-rc6/source/Documentation/process/6.Followthrough.rst#L199
@Andrew: it looks like the firmware interface is going to be limited for the time being, are ok with that?
Cheers,
Paolo
| |