Messages in this thread | | | From | <> | Subject | RE: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration sequences | Date | Thu, 29 Feb 2024 08:59:20 +0000 |
| |
Hi Andrew,
Thank you for review comments.
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: Tuesday, February 27, 2024 7:28 AM > To: Raju Lakkaraju - I30499 <Raju.Lakkaraju@microchip.com> > Cc: netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org; linux- > kernel@vger.kernel.org; Bryan Whitehead - C21958 > <Bryan.Whitehead@microchip.com>; richardcochran@gmail.com; > UNGLinuxDriver <UNGLinuxDriver@microchip.com> > Subject: Re: [PATCH net 3/3] net: lan743x: Address problems with wake option > flags configuration sequences > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, Feb 26, 2024 at 01:39:34PM +0530, Raju Lakkaraju wrote: > > Wake options handling has been reworked as follows: > > a. We only enable secure on magic packet when both secure and magic wol > > options are requested together. > > b. If secure-on magic packet had been previously enabled, and a > subsequent > > command does not include it, we add it. This was done to workaround a > > problem with the 'pm-suspend' application which is unaware of secure-on > > magic packet being enabled and can unintentionally disable it prior to > > putting the system into suspend. > > This seems to be in a bit of a grey area. But ethtool says: > > wol p|u|m|b|a|g|s|f|d... > Sets Wake-on-LAN options. Not all devices support this. > The argument to this option is a string of characters speci‐ > fying which options to enable. > p Wake on PHY activity > u Wake on unicast messages > m Wake on multicast messages > b Wake on broadcast messages > a Wake on ARP > g Wake on MagicPacket™ > s Enable SecureOn™ password for MagicPacket™ > f Wake on filter(s) > d Disable (wake on nothing). This option > clears all previous options. > > d clears everything. All other things enable one option. There does not > appear to be a way to disable a single option, and i would say, adding options > is incremental. >
Yes. "d" clears everything. But, if we enable "g" then enable "a", "g" option overwritten by "a" Please find the attached log information > So: > > > a. We only enable secure on magic packet when both secure and magic wol > > options are requested together. > > I don't think they need to be requested together. I think you can first enable > Wake on MagicPacket and then in a second call to ethtool Enable SecureOn > password for MagicPacket. I also don't think it would unreasonable to accept > Enable SecureOn password for MagicPacket and have that imply Wake on > MagicPacket. >
If we need to enable any 2 options, we have to provide both options together. i.e. sudo ethtool -s enp9s0 wol ga
> And: > > > b. If secure-on magic packet had been previously enabled, and a > subsequent > > command does not include it, we add it. > > If there has not been a d, secure-on magic packet should remain enabled until > there is a d. >
This is not happened with existing "Ethtool". Please find the log information in an attachment file.
> Andrew
Thanks, Raju $ sudo ethtool -s enp9s0 Settings for enp9s0: Supported ports: [ ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Supported pause frame use: Symmetric Receive-only Supports auto-negotiation: Yes Supported FEC modes: Not reported Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Advertised pause frame use: Symmetric Receive-only Advertised auto-negotiation: Yes Advertised FEC modes: Not reported Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Link partner advertised pause frame use: Symmetric Receive-only Link partner advertised auto-negotiation: No Link partner advertised FEC modes: Not reported Speed: 2500Mb/s Duplex: Full Auto-negotiation: on master-slave cfg: preferred slave master-slave status: master Port: Twisted Pair PHYAD: 1 Transceiver: external MDI-X: on (auto) Supports Wake-on: pumbags Wake-on: d SecureOn password: 00:00:00:00:00:00 Current message level: 0x00000137 (311) drv probe link ifdown ifup tx_queued Link detected: yes
$ sudo ethtool -s enp9s0 wol g $ sudo ethtool enp9s0 Settings for enp9s0: Supported ports: [ ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Supported pause frame use: Symmetric Receive-only Supports auto-negotiation: Yes Supported FEC modes: Not reported Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Advertised pause frame use: Symmetric Receive-only Advertised auto-negotiation: Yes Advertised FEC modes: Not reported Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Link partner advertised pause frame use: Symmetric Receive-only Link partner advertised auto-negotiation: No Link partner advertised FEC modes: Not reported Speed: 2500Mb/s Duplex: Full Auto-negotiation: on master-slave cfg: preferred slave master-slave status: master Port: Twisted Pair PHYAD: 1 Transceiver: external MDI-X: on (auto) Supports Wake-on: pumbags Wake-on: g SecureOn password: 00:00:00:00:00:00 Current message level: 0x00000137 (311) drv probe link ifdown ifup tx_queued Link detected: yes
$ sudo ethtool -s enp9s0 wol a $ sudo ethtool enp9s0 Settings for enp9s0: Supported ports: [ ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Supported pause frame use: Symmetric Receive-only Supports auto-negotiation: Yes Supported FEC modes: Not reported Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Advertised pause frame use: Symmetric Receive-only Advertised auto-negotiation: Yes Advertised FEC modes: Not reported Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Link partner advertised pause frame use: Symmetric Receive-only Link partner advertised auto-negotiation: No Link partner advertised FEC modes: Not reported Speed: 2500Mb/s Duplex: Full Auto-negotiation: on master-slave cfg: preferred slave master-slave status: master Port: Twisted Pair PHYAD: 1 Transceiver: external MDI-X: on (auto) Supports Wake-on: pumbags Wake-on: a SecureOn password: 00:00:00:00:00:00 Current message level: 0x00000137 (311) drv probe link ifdown ifup tx_queued Link detected: yes
$ sudo ethtool -s enp9s0 wol ga $ sudo ethtool enp9s0 Settings for enp9s0: Supported ports: [ ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Supported pause frame use: Symmetric Receive-only Supports auto-negotiation: Yes Supported FEC modes: Not reported Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Advertised pause frame use: Symmetric Receive-only Advertised auto-negotiation: Yes Advertised FEC modes: Not reported Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Link partner advertised pause frame use: Symmetric Receive-only Link partner advertised auto-negotiation: No Link partner advertised FEC modes: Not reported Speed: 2500Mb/s Duplex: Full Auto-negotiation: on master-slave cfg: preferred slave master-slave status: master Port: Twisted Pair PHYAD: 1 Transceiver: external MDI-X: on (auto) Supports Wake-on: pumbags Wake-on: ag SecureOn password: 00:00:00:00:00:00 Current message level: 0x00000137 (311) drv probe link ifdown ifup tx_queued Link detected: yes
raju-project-pc@ ~$ sudo ethtool -s enp9s0 wol b raju-project-pc@ ~$ sudo ethtool enp9s0 Settings for enp9s0: Supported ports: [ ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Supported pause frame use: Symmetric Receive-only Supports auto-negotiation: Yes Supported FEC modes: Not reported Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Advertised pause frame use: Symmetric Receive-only Advertised auto-negotiation: Yes Advertised FEC modes: Not reported Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Link partner advertised pause frame use: Symmetric Receive-only Link partner advertised auto-negotiation: No Link partner advertised FEC modes: Not reported Speed: 2500Mb/s Duplex: Full Auto-negotiation: on master-slave cfg: preferred slave master-slave status: master Port: Twisted Pair PHYAD: 1 Transceiver: external MDI-X: on (auto) Supports Wake-on: pumbags Wake-on: b SecureOn password: 00:00:00:00:00:00 Current message level: 0x00000137 (311) drv probe link ifdown ifup tx_queued Link detected: yes
$ sudo ethtool enp9s0 Settings for enp9s0: Supported ports: [ ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Supported pause frame use: Symmetric Receive-only Supports auto-negotiation: Yes Supported FEC modes: Not reported Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Advertised pause frame use: Symmetric Receive-only Advertised auto-negotiation: Yes Advertised FEC modes: Not reported Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Link partner advertised pause frame use: Symmetric Receive-only Link partner advertised auto-negotiation: No Link partner advertised FEC modes: Not reported Speed: 2500Mb/s Duplex: Full Auto-negotiation: on master-slave cfg: preferred slave master-slave status: master Port: Twisted Pair PHYAD: 1 Transceiver: external MDI-X: on (auto) Supports Wake-on: pumbags Wake-on: g SecureOn password: 00:00:00:00:00:00 Current message level: 0x00000137 (311) drv probe link ifdown ifup tx_queued Link detected: yes
$ sudo ethtool -s enp9s0 wol s $ sudo ethtool enp9s0 Settings for enp9s0: Supported ports: [ ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Supported pause frame use: Symmetric Receive-only Supports auto-negotiation: Yes Supported FEC modes: Not reported Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Advertised pause frame use: Symmetric Receive-only Advertised auto-negotiation: Yes Advertised FEC modes: Not reported Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full 2500baseT/Full Link partner advertised pause frame use: Symmetric Receive-only Link partner advertised auto-negotiation: No Link partner advertised FEC modes: Not reported Speed: 2500Mb/s Duplex: Full Auto-negotiation: on master-slave cfg: preferred slave master-slave status: master Port: Twisted Pair PHYAD: 1 Transceiver: external MDI-X: on (auto) Supports Wake-on: pumbags Wake-on: d SecureOn password: 00:00:00:00:00:00 Current message level: 0x00000137 (311) drv probe link ifdown ifup tx_queued Link detected: yes
| |