Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 29 Feb 2024 08:29:47 +0100 | Subject | Re: [PATCH 2/6] PCI: imx6: Rename pci-imx6.c and PCI_IMX6 config | From | Ahmad Fatoum <> |
| |
Hello Frank,
On 29.02.24 00:36, Frank Li wrote: > On Wed, Feb 28, 2024 at 05:05:20PM -0600, Bjorn Helgaas wrote: >> On Tue, Feb 27, 2024 at 04:47:09PM -0500, Frank Li wrote: >>> -config PCI_IMX6 >>> +config PCI_IMX >> >> What does this look like to users who carry an old .config file >> forward? > > I don't think people will use old .config when update to new kernel. I can > keep PCI_IMX6 for config if have to.
I'd argue it's the complete opposite. Most users don't use the in-tree defconfig, but use olddefconfig on their customized .config, either explicitly or implicitly via menuconfig and saving.
This would result in non-functional PCI after an update. I don't mind renaming the file, but please leave the Kconfig symbol as-is.
Thanks, Ahmad
> > > >
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| ![\](/images/icornerr.gif) |