Messages in this thread | ![/](/images/icornerl.gif) | | From | Thomas Gleixner <> | Subject | Re: [PATCH v2] x86/mtrr: Check if fixed MTRRs exist before saving them | Date | Thu, 29 Feb 2024 00:26:26 +0100 |
| |
On Wed, Jan 10 2024 at 07:08, Andi Kleen wrote: > This one place forgot to check the fixed capability.
This one place forgot? And what the heck is a fixed capability?
> Otherwise there will a harmless but ugly WARN_ON for the failed WRMSR > when the MSR doesn't exist.
This is not a sentence as it lacks a verb,
Also it does not matter whether you think that the WARN_ON() is ugly or not. Can you please write a changelog in technical terms?
> Noticed when testing X86S support.
Who cares?
> Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before")
This fixes tag is pointlessly truncated. The correct one is:
Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before booting an AP")
It's not rocket science to copy & pasta correctly.
Thanks,
tglx
| ![\](/images/icornerr.gif) |