lkml.org 
[lkml]   [2024]   [Feb]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] x86/mtrr: Check if fixed MTRRs exist before saving them
Date
On Wed, Jan 10 2024 at 07:08, Andi Kleen wrote:
> This one place forgot to check the fixed capability.

This one place forgot? And what the heck is a fixed capability?

> Otherwise there will a harmless but ugly WARN_ON for the failed WRMSR
> when the MSR doesn't exist.

This is not a sentence as it lacks a verb,

Also it does not matter whether you think that the WARN_ON() is ugly or
not. Can you please write a changelog in technical terms?

> Noticed when testing X86S support.

Who cares?

> Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before")

This fixes tag is pointlessly truncated. The correct one is:

Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before booting an AP")

It's not rocket science to copy & pasta correctly.

Thanks,

tglx

\
 
 \ /
  Last update: 2024-05-27 15:27    [W:0.089 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site