Messages in this thread | | | From | Enric Balletbo i Serra <> | Date | Thu, 29 Feb 2024 00:11:59 +0100 | Subject | Re: [PATCH] drm/tidss: Use dev_err_probe() over dev_dbg() when failing to probe the port |
| |
Hello Andrew,
Many thanks for proposing this.
On Wed, Feb 28, 2024 at 11:02 PM Javier Martinez Canillas <javierm@redhat.com> wrote: > > Andrew Halaney <ahalaney@redhat.com> writes: > > Hello Andrew, > > > This gets logged out to /sys/kernel/debug/devices_deferred in the > > -EPROBE_DEFER case and as an error otherwise. The message here provides > > useful information to the user when troubleshooting why their display is > > not working in either case, so let's make it output appropriately. > > > > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > > --- > > There's definitely more spots in this driver that could be upgraded from > > dev_dbg() to something more appropriate, but this one burned me today so > > I thought I'd send a patch for it specifically before I forget. > > --- > > Makes sense to me and I agree that's useful to have that information there. > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> >
Logging in /sys/kernel/debug/devices_deferred was useful for me, so
Tested-by: Enric Balletbo i Serra <eballetbo@kernel.org>
Cheers, Enric
> -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat >
| |