Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 29 Feb 2024 13:32:53 -0800 | From | Kees Cook <> | Subject | Re: [PATCH] sparc: vdso: Disable UBSAN instrumentation |
| |
On Thu, Feb 29, 2024 at 10:00:38PM +0200, Andy Shevchenko wrote: > On Fri, Feb 23, 2024 at 08:59:45AM -0800, Kees Cook wrote: > > The UBSAN instrumentation cannot work in the vDSO since it is executing > > in userspace, so disable it in the Makefile. Fixes the build failures > > such as: > > > > arch/sparc/vdso/vclock_gettime.c:217: undefined reference to `__ubsan_handle_shift_out_of_bounds' > > > > Signed-off-by: Kees Cook <keescook@chromium.org> > > --- > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: Andreas Larsson <andreas@gaisler.com> > > Cc: Masahiro Yamada <masahiroy@kernel.org> > > Cc: Sam Ravnborg <sam@ravnborg.org> > > Cc: Helge Deller <deller@gmx.de> > > Cc: Guo Ren <guoren@kernel.org> > > Cc: sparclinux@vger.kernel.org > > I dunno how you applied patches, but these Cc seems to appear in a few commits > in your hardening branch. > > I formatted patch from 9fd54b08040669, checked out the new branch just before > this commit and run `git am 0001-...`. I don't see them.
Ah, hm, yes, I'll need to split up my trees a bit to get the right results. Thanks for pointing that out!
-- Kees Cook
| ![\](/images/icornerr.gif) |