Messages in this thread | | | Date | Thu, 29 Feb 2024 20:25:07 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2] gpio: 74x164: Enable output pins after registers are reset |
| |
On Thu, Feb 29, 2024 at 07:24:09PM +0200, Arturas Moskvinas wrote: > On 2/29/24 15:25, Bartosz Golaszewski wrote: > > On Thu, Feb 29, 2024 at 1:23 PM Arturas Moskvinas > > <arturas.moskvinas@gmail.com> wrote: > > > Chip outputs are enabled[1] before actual reset is performed[2] which might > > > cause pin output value to flip flop if previous pin value was set to 1 > > > in chip. > > > Fix that behavior by making sure chip is fully reset before all outputs are > > > enabled. > > > > > > Bartosz, does this look better? > > ... if previous pin value was set to 1 period > Andriy, Bartosz, is commit message ok?
LGTM! Please, send a v3 with it.
-- With Best Regards, Andy Shevchenko
| |