Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 28 Feb 2024 14:34:16 +0000 | From | Simon Horman <> | Subject | Re: [PATCH net-next 2/2] net: sit: Do not set .ndo_get_stats64 |
| |
On Wed, Feb 28, 2024 at 03:31:22AM -0800, Breno Leitao wrote: > If the driver is using the network core allocation mechanism, by setting > NETDEV_PCPU_STAT_TSTATS, as this driver is, then, it doesn't need to set > the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Since > the network core calls it automatically, and .ndo_get_stats64 should > only be set if the driver needs special treatment. > > This simplifies the driver, since all the generic statistics is now > handled by core. > > Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
| ![\](/images/icornerr.gif) |