lkml.org 
[lkml]   [2024]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 06/11] x86/unwind/orc: Convert global variables to static
On Wed, 28 Feb 2024 16:03:09 -0800
Josh Poimboeuf <jpoimboe@kernel.org> wrote:

> On Wed, Feb 28, 2024 at 06:35:07PM -0500, Steven Rostedt wrote:
> > On Sat, 25 Apr 2020 05:03:05 -0500
> > Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> >
> > > These variables aren't used outside of unwind_orc.c, make them static.
> > >
> > > Also annotate some of them with '__ro_after_init', as applicable.
> >
> > So it appears that crash uses "lookup_num_blocks" to be able to do
> > back-traces with the ORC unwinder. But because it's now static, crash can no
> > longer do that.
>
> Hm, but why? Even a static variable has a known address.
>

I'm guessing because we don't have the full dwarf info?

-- Steve

\
 
 \ /
  Last update: 2024-02-29 01:12    [W:0.162 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site