Messages in this thread | | | Date | Sun, 25 Feb 2024 11:29:53 +0000 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH] ARM: mvebu: Prevent null pointer dereference caused by kzalloc failure |
| |
On Sun, Feb 25, 2024 at 02:04:01PM +0800, Duoming Zhou wrote: > The kzalloc() in i2c_quirk() will return null if the physical > memory has run out. As a result, if we dereference the new_compat > pointer, the null pointer dereference bug will happen. > > This patch adds a check to avoid null pointer dereference.
Yet again another janitorial patch that is Way too focused on a single issue, rather than analysing the code and proposing the best fix. :(
What if the two kstrdup() fail?
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
| |