Messages in this thread | | | Date | Fri, 2 Feb 2024 09:28:44 +0100 | Subject | Re: [PATCH v6 2/2] dt-bindings: rtc: add max313xx RTCs | From | Krzysztof Kozlowski <> |
| |
On 02/02/2024 03:52, Chris Packham wrote: > From: Ibrahim Tilki <Ibrahim.Tilki@analog.com> > > Devicetree binding documentation for Analog Devices MAX313XX RTCs > > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com> > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > ---
..
> + clocks: > + description: > + RTC uses this clock for clock input when supplied. Clock has to provide > + one of these four frequencies - 1Hz, 50Hz, 60Hz or 32.768kHz. > + maxItems: 1 > + > + adi,tc-diode: > + description: > + Select the diode configuration for the trickle charger. > + schottky - Schottky diode in series. > + standard+schottky - standard diode + Schottky diode in series. > + enum: [schottky, standard+schottky] > + > + trickle-resistor-ohms: > + description: Selected resistor for trickle charger. > + enum: [3000, 6000, 11000]
Please remind us and document in commit msg, why this cannot be part of max31335 binding? Looks exactly the same.
> + > +required: > + - compatible > + - reg
Best regards, Krzysztof
| |