Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 18 Feb 2024 01:06:58 -0800 | From | Kees Cook <> | Subject | Re: [PATCH] PM: hibernate: Don't ignore return from set_memory_ro() |
| |
On Sun, Feb 18, 2024 at 09:40:58AM +0100, Christophe Leroy wrote: > set_memory_ro() and set_memory_rw() can fail, leaving memory > unprotected. > > Take the returned value into account and abort in case of > failure. > > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
More set_memory* consumers! :) Error paths look good to me.
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| ![\](/images/icornerr.gif) |