lkml.org 
[lkml]   [2024]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH v3 11/18] phy: cadence-torrent: register resets even if the phy is already configured
    Resets are needed during suspend and resume stages.
    So they shall be registered during the probe even the phy is already
    initialized.

    The function cdns_torrent_reset is renamed cdns_torrent_of_get_reset() to
    make it clear.

    Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
    ---
    drivers/phy/cadence/phy-cadence-torrent.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c
    index 803a76acf2fd..bba10ca0bfdd 100644
    --- a/drivers/phy/cadence/phy-cadence-torrent.c
    +++ b/drivers/phy/cadence/phy-cadence-torrent.c
    @@ -2660,7 +2660,7 @@ static int cdns_torrent_clk_register(struct cdns_torrent_phy *cdns_phy)
    return 0;
    }

    -static int cdns_torrent_reset(struct cdns_torrent_phy *cdns_phy)
    +static int cdns_torrent_of_get_reset(struct cdns_torrent_phy *cdns_phy)
    {
    struct device *dev = cdns_phy->dev;

    @@ -2779,6 +2779,10 @@ static int cdns_torrent_phy_probe(struct platform_device *pdev)
    if (ret)
    return ret;

    + ret = cdns_torrent_of_get_reset(cdns_phy);
    + if (ret)
    + goto clk_cleanup;
    +
    ret = cdns_torrent_of_get_clk(cdns_phy);
    if (ret)
    goto clk_cleanup;
    @@ -2786,10 +2790,6 @@ static int cdns_torrent_phy_probe(struct platform_device *pdev)
    regmap_field_read(cdns_phy->phy_pma_cmn_ctrl_1, &already_configured);

    if (!already_configured) {
    - ret = cdns_torrent_reset(cdns_phy);
    - if (ret)
    - goto clk_cleanup;
    -
    ret = cdns_torrent_clk(cdns_phy);
    if (ret)
    goto clk_cleanup;
    --
    2.39.2


    \
     
     \ /
      Last update: 2024-05-27 15:05    [W:3.848 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site