lkml.org 
[lkml]   [2024]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 07/15] auxdisplay: linedisp: Group line display drivers together
Hi Andy,

On Thu, Feb 15, 2024 at 12:30 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Feb 15, 2024 at 11:05:00AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > obj-$(CONFIG_CHARLCD) += charlcd.o
> > > obj-$(CONFIG_HD44780_COMMON) += hd44780_common.o
> > > -obj-$(CONFIG_ARM_CHARLCD) += arm-charlcd.o
> > > +obj-$(CONFIG_HD44780) += hd44780.o
> > > +obj-$(CONFIG_LCD2S) += lcd2s.o
> > > obj-$(CONFIG_KS0108) += ks0108.o
> > > obj-$(CONFIG_CFAG12864B) += cfag12864b.o cfag12864bfb.o
> > > -obj-$(CONFIG_IMG_ASCII_LCD) += img-ascii-lcd.o
> > > -obj-$(CONFIG_HD44780) += hd44780.o
> > > -obj-$(CONFIG_HT16K33) += ht16k33.o
> > > -obj-$(CONFIG_PARPORT_PANEL) += panel.o
> > > -obj-$(CONFIG_LCD2S) += lcd2s.o
> > > obj-$(CONFIG_LINEDISP) += line-display.o
> > > +obj-$(CONFIG_IMG_ASCII_LCD) += img-ascii-lcd.o
> > > +obj-$(CONFIG_HT16K33) += ht16k33.o
> > > +obj-$(CONFIG_ARM_CHARLCD) += arm-charlcd.o
> > > +obj-$(CONFIG_PARPORT_PANEL) += panel.o
> >
> > IMHO it hurts to not sort Makefile entries alphabetically.
>
> I can add blank lines to follow the same grouping as in Kconfig. Would it work
> for you?

Unlike Kconfig, this is not user-visible.
Most Makefiles use sorted entries. If they look unsorted, people will
just add new entries at the end.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2024-05-27 15:05    [W:0.602 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site