Messages in this thread | | | Date | Thu, 15 Feb 2024 11:40:38 +0100 | Subject | Re: [PATCH 5/9] drm/mediatek: Drop calling cmdq_pkt_finalize() | From | AngeloGioacchino Del Regno <> |
| |
Il 15/02/24 01:49, Chun-Kuang Hu ha scritto: > For some client driver, it want to reduce latency between excuting > previous packet command and next packet command, so append jump > command to the end of previous packet and the jump destination > address is the start address of next packet command buffer. Before > next packet exist, the previous packet has no information of where > to jump to, so append nop command first. When next packet exist, > change nop command to jump command. For mediatek drm driver, it > never has next packet, so appending nop command is redundant. > Because cmdq_pkt_finalize() would append nop command, so change > calling cmdq_pkt_finalize() to cmdq_pkt_eoc() to prevent append > redundant nop command. > > Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Makes sense.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
| |