Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 15 Feb 2024 14:15:58 -0600 | Subject | [PATCH 2/2] x86/MCE: Add command line option to extend MCE Records pool | From | "Naik, Avadhut" <> |
| |
On 2/12/2024 03:32, Borislav Petkov wrote: > On Mon, Feb 12, 2024 at 09:58:01AM +0100, Borislav Petkov wrote: >> * Can you think of a slick deduplication scheme instead of blindly >> raising the buffer size? > > And here's the simplest scheme: you don't extend the buffer. On > overflow, you say "Buffer full, here's the MCE" and you dump the error > long into dmesg. Problem solved. > Wouldn't this require logging in the #MC context?
We would know that the genpool is full in mce_gen_pool_add() which, I think is executed in #MC context.
> A slicker deduplication scheme would be even better, tho. Maybe struct > mce.count which gets incremented instead of adding the error record to > the buffer again. And so on... >
-- Thanks, Avadhut Naik
| ![\](/images/icornerr.gif) |