lkml.org 
[lkml]   [2024]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip: irq/msi] irqchip/gic-v3: Make gic_irq_domain_select() robust for zero parameter count
    The following commit has been merged into the irq/msi branch of tip:

    Commit-ID: 15137825100422c4c393c87af5aa5a8fa297b1f3
    Gitweb: https://git.kernel.org/tip/15137825100422c4c393c87af5aa5a8fa297b1f3
    Author: Thomas Gleixner <tglx@linutronix.de>
    AuthorDate: Sat, 27 Jan 2024 21:47:29 +05:30
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitterDate: Thu, 15 Feb 2024 17:55:39 +01:00

    irqchip/gic-v3: Make gic_irq_domain_select() robust for zero parameter count

    Currently the irqdomain select callback is only invoked when the parameter
    count of the fwspec arguments is not zero. That makes sense because then
    the match is on the firmware node and eventually on the bus_token, which is
    already handled in the core code.

    The upcoming support for per device MSI domains requires to do real bus
    token specific checks in the MSI parent domains with a zero parameter
    count.

    Make the gic-v3 select() callback handle that case.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Anup Patel <apatel@ventanamicro.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Acked-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/20240127161753.114685-2-apatel@ventanamicro.com

    ---
    drivers/irqchip/irq-gic-v3.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
    index 98b0329..35b9362 100644
    --- a/drivers/irqchip/irq-gic-v3.c
    +++ b/drivers/irqchip/irq-gic-v3.c
    @@ -1702,9 +1702,13 @@ static int gic_irq_domain_select(struct irq_domain *d,
    irq_hw_number_t hwirq;

    /* Not for us */
    - if (fwspec->fwnode != d->fwnode)
    + if (fwspec->fwnode != d->fwnode)
    return 0;

    + /* Handle pure domain searches */
    + if (!fwspec->param_count)
    + return d->bus_token == bus_token;
    +
    /* If this is not DT, then we have a single domain */
    if (!is_of_node(fwspec->fwnode))
    return 1;
    \
     
     \ /
      Last update: 2024-05-27 15:05    [W:4.099 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site