Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v2 1/2] alarmtimer: Create alarmtimer sysfs to make duration of kernel suspend check configurable | Date | Tue, 13 Feb 2024 13:29:39 +0100 |
| |
On Fri, Feb 09 2024 at 12:01, John Stultz wrote: > On Thu, Feb 8, 2024 at 11:56 AM Pranav Prasad <pranavpp@google.com> wrote: >> >> Currently, the alarmtimer_suspend does not allow the kernel >> to suspend if the next alarm is within 2 seconds. >> Create alarmtimer sysfs to make the value of 2 seconds configurable. >> This allows flexibility to provide a different value based on the >> type of device running the Linux kernel. As a data point, about 40% of >> kernel suspend failures in a subset of Android devices were due to >> this check. A differently configured value can avoid these suspend >> failures which performs a lot of additional work affecting the >> power consumption of these Android devices. >> >> Signed-off-by: Pranav Prasad <pranavpp@google.com> > > I might suggest flipping the order of these two patches, as I'm more > wary of UABI changes, so I don't want to hold up the second patch on > interface bike shedding.
Correct. It's an orthogonal issue and an optimization on top of the early check.
Thanks,
tglx
| |