Messages in this thread | | | Subject | Re: [RFC PATCH net-next v2 1/7] net: ravb: Simplify poll & receive functions | From | Sergey Shtylyov <> | Date | Sat, 10 Feb 2024 19:13:43 +0300 |
| |
On 2/6/24 12:19 PM, Paul Barker wrote:
> We don't need to pass the work budget to ravb_rx() by reference, it's > cleaner to pass this by value and return the amount of work done. This > allows us to simplify the ravb_poll() function and use the common > `work_done` variable name seen in other network drivers for consistency > and ease of understanding. > > In ravb_rx_gbeth() & ravb_rx_rcar(), we can also drop the confusingly > named `boguscnt` variable and use a for loop to iterate through > descriptors. > > This is a pure refactor and should not affect behaviour. > > Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
| |