Messages in this thread | | | Date | Thu, 1 Feb 2024 16:30:30 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2] pinctrl: mcp23s08: Check only GPIOs which have interrupts enabled |
| |
On Thu, Feb 01, 2024 at 04:14:07PM +0200, Arturas Moskvinas wrote: > GPINTEN register contains information about GPIOs with enabled > interrupts no need to check other GPIOs for changes. > > Signed-off-by: Arturas Moskvinas <arturas.moskvinas@gmail.com> > ---
You forgot to add a changelog here, but no need to resend, just you can respond to the email since it's not a big issue in this case.
..
> + if (mcp_read(mcp, MCP_GPINTEN, &gpinten)) > + goto unlock;
Do all hw variants have this register available? Esp. I2C part, wouldn't it be problematic (exception with NACK on the bus)?
..
The rest LGTM, thanks!
-- With Best Regards, Andy Shevchenko
| |