Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 1 Feb 2024 05:36:53 -0800 | Subject | Re: [PATCH v2 02/11] watchdog: rzg2l_wdt: Select PM | From | Guenter Roeck <> |
| |
On 2/1/24 00:52, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Thu, Feb 1, 2024 at 2:30 AM Claudiu <claudiu.beznea@tuxon.dev> wrote: >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >> >> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the >> clocks are enabled though pm_runtime_* specific APIs). To avoid building >> a driver that don't work select CONFIG_PM. >> >> Suggested-by: Guenter Roeck <linux@roeck-us.net> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Thanks for your patch! > >> --- a/drivers/watchdog/Kconfig >> +++ b/drivers/watchdog/Kconfig >> @@ -912,6 +912,7 @@ config RENESAS_RZG2LWDT >> tristate "Renesas RZ/G2L WDT Watchdog" >> depends on ARCH_RENESAS || COMPILE_TEST >> select WATCHDOG_CORE >> + select PM > > depends on PM >
Yes, I did not want to suggest that the driver should _select_ PM. Sorry that I wasn't more specific.
Guenter
> The availability of PM is architecture/platform-specific, hence it > must not be selected by individual drivers. > >> help >> This driver adds watchdog support for the integrated watchdogs in the >> Renesas RZ/G2L SoCs. These watchdogs can be used to reset a system. > > Gr{oetje,eeting}s, > > Geert > > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
| ![\](/images/icornerr.gif) |