Messages in this thread |  | | From | Eric Dumazet <> | | Date | Wed, 4 Dec 2024 08:21:58 +0100 | | Subject | Re: [PATCH] tcp: replace head->tstamp with head->skb_mstamp_ns in tcp_tso_should_defer() |
| |
On Wed, Dec 4, 2024 at 3:36 AM <mengensun88@gmail.com> wrote: > > From: MengEn Sun <mengensun@tencent.com> > > The tstamp field of sk_buff is intended to implement SO_TIMESTAMP*. > However, the skb in the RTX queue does not have this field set. > Using this field in tcp_tso_should_defer() can confuse readers of > the code. > > Therefore, in this function, we replace tstamp with skb_mstamp_ns > to obtain the timestamp of when a packet is sent. >
I do not see why this patch would be needed, we have many places in TCP using skb->tstamp just fine.
Do not be confused by unions, this would be my advice :)
|  |