Messages in this thread |  | | Date | Mon, 2 Dec 2024 12:59:21 +0100 | | From | Pavel Machek <> | | Subject | Re: [PATCH AUTOSEL 5.10 3/6] can: j1939: fix error in J1939 documentation. |
| |
Hi!
> From: Alexander Hölzl <alexander.hoelzl@gmx.net> > > [ Upstream commit b6ec62e01aa4229bc9d3861d1073806767ea7838 ] > > The description of PDU1 format usage mistakenly referred to PDU2 > format.
I'm pretty sure this does not fix user-visible bug.
BR, Pavel
> Signed-off-by: Alexander Hölzl <alexander.hoelzl@gmx.net> > Acked-by: Oleksij Rempel <o.rempel@pengutronix.de> > Acked-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> > Link: https://patch.msgid.link/20241023145257.82709-1-alexander.hoelzl@gmx.net > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > Documentation/networking/j1939.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst > index 0a4b73b03b997..59f81ba411608 100644 > --- a/Documentation/networking/j1939.rst > +++ b/Documentation/networking/j1939.rst > @@ -83,7 +83,7 @@ format, the Group Extension is set in the PS-field. > > On the other hand, when using PDU1 format, the PS-field contains a so-called > Destination Address, which is _not_ part of the PGN. When communicating a PGN > -from user space to kernel (or vice versa) and PDU2 format is used, the PS-field > +from user space to kernel (or vice versa) and PDU1 format is used, the PS-field > of the PGN shall be set to zero. The Destination Address shall be set > elsewhere. >
-- People of Russia, stop Putin before his war on Ukraine escalates. [unhandled content-type:application/pgp-signature] |  |