Messages in this thread |  | | From | Anand Moon <> | | Date | Mon, 2 Dec 2024 21:31:26 +0530 | | Subject | Re: [PATCH v3 0/6] RK3399: PCie Phy using new helper function |
| |
Hi All,
On Sat, 12 Oct 2024 at 12:49, Anand Moon <linux.amoon@gmail.com> wrote: > > Few clean of the phy change and Using guard notation makes the code > more compact and error handling for mutex_lock/mutex_unlock. > > Plz review te code changes, I tend to do silly mistake. > > v1: > [1] https://lore.kernel.org/all/20240901183221.240361-5-linux.amoon@gmail.com/ > v2: Fix some typo in the subjects. > [2] https://lore.kernel.org/all/20241006182445.3713-1-linux.amoon@gmail.com/ >
Do you have any device comments on these code changes?
> Thanks > -Anand > Thank -Anand
> Anand Moon (6): > phy: rockchip-pcie: Simplify error handling with dev_err_probe() > phy: rockchip-pcie: Use devm_clk_get_enabled() helper > phy: rockchip-pcie: Use regmap_read_poll_timeout() for PCIe reference > clk PLL status > phy: rockchip-pcie: Refactor mutex handling in > rockchip_pcie_phy_power_off() > phy: rockchip-pcie: Refactor mutex handling in > rockchip_pcie_phy_power_on() > phy: rockchip-pcie: Use guard notation when acquiring mutex > > drivers/phy/rockchip/phy-rockchip-pcie.c | 148 +++++++---------------- > 1 file changed, 47 insertions(+), 101 deletions(-) > > > base-commit: 09f6b0c8904bfaa1e0601bc102e1b6aa6de8c98f > -- > 2.44.0 >
|  |