Messages in this thread |  | | From | Geert Uytterhoeven <> | | Date | Thu, 19 Dec 2024 10:55:19 +0100 | | Subject | Re: [PATCH RFT 2/6] serial: sh-sci: Drop __initdata macro for port_cfg |
| |
Hi Claudiu,
On Wed, Dec 4, 2024 at 4:58 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > The port_cfg object is used by serial_console_write(), which serves as > the write function for the earlycon device. Marking port_cfg as __initdata > causes it to be freed after kernel initialization, resulting in earlycon > becoming unavailable thereafter. Remove the __initdata macro from port_cfg > to resolve this issue.
Thanks for your patch!
> Fixes: dd076cffb8cd ("serial: sh-sci: Fix init data attribute for struct 'port_cfg'")
This commit is not the root cause, as it merely replaced __init by __initdata.
Fixes: 0b0cced19ab15c9e ("serial: sh-sci: Add CONFIG_SERIAL_EARLYCON support")
For the patch contents: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|  |