Messages in this thread |  | | From | Linus Torvalds <> | | Date | Sat, 30 Nov 2024 13:34:06 -0800 | | Subject | Re: [PATCH] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case |
| |
On Sat, 30 Nov 2024 at 12:28, Mateusz Guzik <mjguzik@gmail.com> wrote: > > > + /* The dentry name won't change while we hold the rcu read lock. */ > > + __set_task_comm(me, smp_load_acquire(&bprm->file->f_path.dentry->d_name.name), > > + true); > > This does not sound legit whatsoever as it would indicate all renames > wait for rcu grace periods to end, which would be prettye weird.
Yes, the "won't change" should be "won't go away from under us".
Linus
|  |