Messages in this thread |  | | From | Alexei Starovoitov <> | | Date | Thu, 28 Nov 2024 11:05:12 -0800 | | Subject | Re: [PATCH bpf-next v3 2/2] bpf: Refactor bpf_tracing_func_proto() and remove bpf_get_probe_write_proto() |
| |
On Thu, Nov 28, 2024 at 10:36 AM Marco Elver <elver@google.com> wrote: > > On Thu, Nov 28, 2024 at 10:22AM -0800, Alexei Starovoitov wrote: > [..] > > Moving bpf_base_func_proto() all the way to the top was incorrect, > > but here we can move it just above this bpf_token_capable() check > > and remove extra indent like: > > > > func_proto = bpf_base_func_proto(); > > if (func_proto) > > return func_proto; > > if (!bpf_token_capable(prog->aux->token, CAP_SYS_ADMIN)) > > return NULL; > > switch (func_id) { > > case BPF_FUNC_probe_write_user: > > > > that will align it with the style of bpf_base_func_proto(). > > > > pw-bot: cr > > Ack, let me change that. > > Below is preview of v4 for this bit.
lgtm
|  |