Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 8 Jan 2024 14:31:50 -0800 | Subject | Re: [PATCH v2 1/4] selftests/resctrl: Add test groups and name L3 CAT test L3_CAT | From | Reinette Chatre <> |
| |
Hi Maciej,
On 12/12/2023 6:52 AM, Maciej Wieczor-Retman wrote: > From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > > To select test to run -t parameter can be used. However, -t cat > currently maps to L3 CAT test which is confusing after more CAT related > tests are added. > > Allow selecting tests as groups and call L3 CAT test "L3_CAT", "CAT" > group will enable all CAT related tests. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com> > --- > Changelog v2: > - Move this patch from Ilpo's series here (Ilpo). > > tools/testing/selftests/resctrl/cat_test.c | 3 ++- > tools/testing/selftests/resctrl/resctrl.h | 2 ++ > tools/testing/selftests/resctrl/resctrl_tests.c | 16 +++++++++++----- > 3 files changed, 15 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c > index 24af8310288a..39fc9303b8e8 100644 > --- a/tools/testing/selftests/resctrl/cat_test.c > +++ b/tools/testing/selftests/resctrl/cat_test.c > @@ -295,7 +295,8 @@ static int cat_run_test(const struct resctrl_test *test, const struct user_param > } > > struct resctrl_test l3_cat_test = { > - .name = "CAT", > + .name = "L3_CAT", > + .group = "CAT", > .resource = "L3", > .feature_check = test_resource_feature_check, > .run_test = cat_run_test, > diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h > index c54efcf1412a..739e16d08a7b 100644 > --- a/tools/testing/selftests/resctrl/resctrl.h > +++ b/tools/testing/selftests/resctrl/resctrl.h > @@ -65,6 +65,7 @@ struct user_params { > /* > * resctrl_test: resctrl test definition > * @name: Test name > + * @group: Test group (e.g., L2 and L3 CAT test belong to CAT group), can be NULL
Could you please remove references to L2 CAT test that is not available yet? A detailed description of what a test group is will be helpful.
Reinette
| ![\](/images/icornerr.gif) |