Messages in this thread | | | Date | Sun, 7 Jan 2024 10:56:23 +0300 | From | Vitaly Chikunov <> | Subject | Re: [PATCH v4] net: 9p: avoid freeing uninit memory in p9pdu_vreadf |
| |
Dominique,
On Tue, Dec 12, 2023 at 08:21:30AM +0900, Dominique Martinet wrote: > Christian Schoenebeck wrote on Thu, Dec 07, 2023 at 01:54:02PM +0100: > > I just checked whether this could create a leak, but it looks clean, so LGTM: > > Right, either version look good to me.
Also, there was unnoticed bug in v2[1] - `int i` is moved to outer block and `i` counld be used uninitialized inside of `if (errcode) {`.
Thanks,
[1] https://lore.kernel.org/all/20231205091952.24754-1-pchelkin@ispras.ru/
> I don't have a hard preference here, I've finished testing and just > updated the patch -- thanks for your comments & review > (and thanks Simon as well!) > > -- > Dominique Martinet | Asmadeus
| |