Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | "Gan, Yi Fang" <> | Subject | [PATCH net v3 1/1] net: phylink: Add module_exit() | Date | Thu, 4 Jan 2024 18:12:55 +0800 |
| |
In delete_module(), if mod->init callback is defined but mod->exit callback is not defined, it will assume the module cannot be removed and return EBUSY. The module_exit() is missing from current phylink module drive causing failure while unloading it.
This patch introduces phylink_exit() for phylink module removal.
Fixes: eca68a3c7d05 ("net: phylink: pass supported host PHY interface modes to phylib for SFP's PHYs") Cc: <stable@vger.kernel.org> # 6.1+ Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@intel.com> Signed-off-by: Gan, Yi Fang <yi.fang.gan@intel.com> --- v1 -> v2: Introduce a macro function to reduce the boilerplate
v2 -> v3: Remove the macro function as it is rejected and fix the format issue suggested from v1
drivers/net/phy/phylink.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 25c19496a336..4a05cda74d42 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -3726,5 +3726,11 @@ static int __init phylink_init(void) module_init(phylink_init); +static void __exit phylink_exit(void) +{ +} + +module_exit(phylink_exit); + MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("phylink models the MAC to optional PHY connection"); -- 2.34.1
| ![\](/images/icornerr.gif) |