Messages in this thread |  | | From | <> | | Subject | Re: [PATCH net-next v2 2/2] net: dsa: Add KSZ8567 switch support | | Date | Tue, 30 Jan 2024 04:03:32 +0000 |
| |
Hi Philippe,
On Thu, 2024-01-25 at 09:05 +0100, Philippe Schenker wrote: > > diff --git a/include/linux/platform_data/microchip-ksz.h > b/include/linux/platform_data/microchip-ksz.h > index f177416635a2..c4466e56d9d7 100644 > --- a/include/linux/platform_data/microchip-ksz.h > +++ b/include/linux/platform_data/microchip-ksz.h > @@ -24,6 +24,7 @@ > > enum ksz_chip_id { > KSZ8563_CHIP_ID = 0x8563, > + KSZ8567_CHIP_ID = 0x00856700, > KSZ8795_CHIP_ID = 0x8795, > KSZ8794_CHIP_ID = 0x8794, > KSZ8765_CHIP_ID = 0x8765,
nitpick: can you move KSZ8567 adjacent to KSZ9567. Since first KSZ8x chips have chipid of 16 bits length. Others have 32 bits length.
otherwise it looks good to me.
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com> > -- > 2.34.1 >
|  |