lkml.org 
[lkml]   [2024]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net-next v2 2/2] net: dsa: Add KSZ8567 switch support
Date
Hi Philippe,

On Thu, 2024-01-25 at 09:05 +0100, Philippe Schenker wrote:
>
> diff --git a/include/linux/platform_data/microchip-ksz.h
> b/include/linux/platform_data/microchip-ksz.h
> index f177416635a2..c4466e56d9d7 100644
> --- a/include/linux/platform_data/microchip-ksz.h
> +++ b/include/linux/platform_data/microchip-ksz.h
> @@ -24,6 +24,7 @@
>
> enum ksz_chip_id {
> KSZ8563_CHIP_ID = 0x8563,
> + KSZ8567_CHIP_ID = 0x00856700,
> KSZ8795_CHIP_ID = 0x8795,
> KSZ8794_CHIP_ID = 0x8794,
> KSZ8765_CHIP_ID = 0x8765,

nitpick: can you move KSZ8567 adjacent to KSZ9567. Since first KSZ8x
chips have chipid of 16 bits length. Others have 32 bits length.

otherwise it looks good to me.

Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
> --
> 2.34.1
>
\
 
 \ /
  Last update: 2024-05-27 14:39    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog