Messages in this thread | | | Date | Tue, 30 Jan 2024 18:09:14 +0100 | Subject | Re: fpga: dfl: fme: Return directly after a failed devm_kasprintf() call in fme_perf_pmu_register() | From | Markus Elfring <> |
| |
>> Thus return directly after a failed devm_kasprintf() call. >> >> Fixes: 724142f8c42a7 ("fpga: dfl: fme: add performance reporting support") > > This basically doesn't affect runtime because perf_pmu_register() checks > for NULL so no need for a Fixes tag.
I suggest to clarify this view a bit more also according to statements like the following.
1. https://elixir.bootlin.com/linux/v6.8-rc2/source/kernel/events/core.c#L11532 perf_pmu_register: … pmu->name = name; …
2. https://elixir.bootlin.com/linux/v6.8-rc2/source/kernel/events/core.c#L11472 pmu_dev_alloc: … ret = dev_set_name(pmu->dev, "%s", pmu->name); …
Regards, Markus
| |