Messages in this thread | ![/](/images/icornerl.gif) | | From | Pratyush Yadav <> | Subject | Re: [PATCH 1/4] mtd: spi-nor: print flash ID instead of name | Date | Mon, 29 Jan 2024 14:12:43 +0100 |
| |
On Fri, Dec 15 2023, Tudor Ambarus wrote:
> We saw flash ID collisions which make the flash name unreliable. Print > the manufacgturer and device ID instead of the flash name.
Typo. s/manufacgturer/manufacturer/
> > Lower the print to dev_dbg to stop polluting the kernel log.
FWIW, I find these prints to be somewhat useful. they serve to "announce" that the kernel probed a device successfully. This can be somewhat helpful when reading logs from customers trying to figure out why something doesn't work.
I don't have any strong opinions of course since it is not such a big deal but I wanted to point out that these prints _are_ somewhat useful.
Acked-by: Pratyush Yadav <pratyush@kernel.org>
> Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com> > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
-- Regards, Pratyush Yadav
| ![\](/images/icornerr.gif) |