lkml.org 
[lkml]   [2024]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] soc: qcom: rpmh-rsc: Enhance check for VREG in-flight request
From
Hi,

On 1/19/2024 9:17 PM, Andrew Halaney wrote:

>> Signed-off-by: Maulik Shah <quic_mkshah@quicinc.com>
>> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
>
> Just noticed I commented on v1 when v2 was already out, sorry. Copy
> pasting this just to keep it on the latest thread:
>
> Two minor things:
>
> 1. Does this deserve a Fixes: tag?
> 2. The Signed-off-by chain here confuses me, you sent the patch
> so your SOB should be last, but then that makes me believe Elliot
> was the author which I don't think is reflected here (no From:
> line). Please read [0] for a bit more details
>
> [0] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

Yes, this looks good to have patch, will include fixes: tag and will
fix SOB in v3.

Thanks,
Maulik

\
 
 \ /
  Last update: 2024-05-27 14:37    [W:0.078 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site