Messages in this thread | | | From | Linus Walleij <> | Date | Sun, 28 Jan 2024 01:12:50 +0100 | Subject | Re: [PATCH 01/14] gpio: pca953x: move suspend/resume to suspend_noirq/resume_noirq |
| |
On Fri, Jan 19, 2024 at 6:01 PM Thomas Richard <thomas.richard@bootlin.com> wrote: > On 1/16/24 08:43, Tony Lindgren wrote: > > * Thomas Richard <thomas.richard@bootlin.com> [240115 16:16]: > >> Some IOs can be needed during suspend_noirq/resume_noirq. > >> So move suspend/resume callbacks to noirq. > > > > So have you checked that the pca953x_save_context() and restore works > > this way? There's i2c traffic and regulators may sleep.. I wonder if > > you instead just need to leave gpio-pca953x enabled in some cases > > instead? > > > > Yes I tested it, and it works (with my setup). > But this patch may have an impact for other people. > How could I leave it enabled in some cases ?
I guess you could define both pca953x_suspend() and pca953x_suspend_noirq() and selectively bail out on one path on some systems?
Worst case using if (of_machine_is_compatible("my,machine"))...
Yours, Linus Walleij
| |