Messages in this thread |  | | Date | Fri, 26 Jan 2024 16:40:39 +0800 | | Subject | Re: [PATCH 3/4] crypto: hisilicon/sec2 - fix some cleanup issues | | From | taoqi <> |
| |
On 2024/1/25 17:37, Herbert Xu wrote: > On Fri, Dec 29, 2023 at 02:44:20PM +0800, Qi Tao wrote: >> >> @@ -1371,7 +1371,7 @@ static int sec_skcipher_bd_fill_v3(struct sec_ctx *ctx, struct sec_req *req) >> sec_sqe3->bd_param = cpu_to_le32(bd_param); >> >> sec_sqe3->c_len_ivin |= cpu_to_le32(c_req->c_len); >> - sec_sqe3->tag = cpu_to_le64(req); >> + sec_sqe3->tag = cpu_to_le64((unsigned long)(uintptr_t)req); > > Please explain why you're casting twice. > > Thanks,
I'm sorry. I made a mistake here. unsigned long and uintptr_t are the same data type in linux kernel. The type cast is invalidly repeated here. Can I just keep (unsigned long) one cast?
|  |