lkml.org 
[lkml]   [2024]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] eventfs: Have inodes have unique inode numbers
    On Fri, 26 Jan 2024 at 13:26, Steven Rostedt <rostedt@goodmis.org> wrote:
    >
    > So we keep the same inode number until something breaks with it, even
    > though, using unique ones is not that complicated?

    Using unique ones for directories was a trivial cleanup.

    The file case is clearly different. I thought it would be the same
    trivial one-liner, but nope.

    When you have to add 30 lines of code just to get unique inode numbers
    that nobody has shown any interest in, it's 30 lines too much.

    And when it happens in a filesystem that has a history of copying code
    from the VFS layer and having nasty bugs, it's *definitely* too much.

    Simplify. If you can clean things up and we have a few release of
    not-horrendous-bugs every other day, I may change my mind.

    As it is, I feel like I have to waste my time checking all your
    patches, and I'm saying "it's not worth it".

    Linus

    \
     
     \ /
      Last update: 2024-05-27 14:35    [W:3.672 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site