Messages in this thread |  | | Date | Thu, 25 Jan 2024 17:10:45 +0000 | | From | Conor Dooley <> | | Subject | Re: [PATCH v2] riscv: dts: sophgo: add watchdog dt node for CV1800 |
| |
On Thu, Jan 25, 2024 at 01:39:51PM +0100, Krzysztof Kozlowski wrote: > On 25/01/2024 10:46, AnnanLiu wrote: > > + > > + pclk: pclk { > > + #clock-cells = <0>; > > + compatible = "fixed-clock"; > > + clock-frequency = <25000000>; > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). >
> Also, why do you describe internal clock as stub?
Under the --- line it says the patch depends on the clock series, but as you pointed out the clock is a "fake" stub, so I don't understand what the dependency would be. [unhandled content-type:application/pgp-signature] |  |