Messages in this thread | ![/](/images/icornerl.gif) | | From | Dmitry Baryshkov <> | Date | Tue, 23 Jan 2024 18:42:38 +0200 | Subject | Re: [PATCH 1/2] phy: qcom-qmp-usb: fix register offsets for ipq8074/ipq6018 |
| |
On Tue, 23 Jan 2024 at 18:09, Mantas Pucka <mantas@8devices.com> wrote: > > Commit 2be22aae6b18 ("phy: qcom-qmp-usb: populate offsets configuration") > introduced register offsets to the driver but for ipq8074/ipq6018 they do > not match what was in the old style device tree. Example from old > ipq6018.dtsi: > > <0x00078200 0x130>, /* Tx */ > <0x00078400 0x200>, /* Rx */ > <0x00078800 0x1f8>, /* PCS */ > <0x00078600 0x044>; /* PCS misc */ > > which would translate to: > {.., .pcs = 0x800, .pcs_misc = 0x600, .tx = 0x200, .rx = 0x400 } > > but was translated to: > {.., .pcs = 0x600, .tx = 0x200, .rx = 0x400 }
Even worse, it was translated to { ... .pcs = 0xc00, .pcs_misc = 0xa00 ... }
With this fixed:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > So split usb_offsets and fix USB initialization for IPQ8074 and IPQ6018. > Tested only on IPQ6018 > > Fixes: 2be22aae6b18 ("phy: qcom-qmp-usb: populate offsets configuration") > Signed-off-by: Mantas Pucka <mantas@8devices.com> > --- > drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-)
-- With best wishes Dmitry
| ![\](/images/icornerr.gif) |