lkml.org 
[lkml]   [2024]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] spi: Raise limit on number of chip selects
On Tue, Jan 23, 2024 at 01:26:04PM +0000, Christophe Leroy wrote:
> Le 23/01/2024 à 14:18, Mark Brown a écrit :
> > On Tue, Jan 23, 2024 at 12:04:30PM +0100, Herve Codina wrote:

> >> Moving the SPI_CS_CNT_MAX value from 4 to 8 is not enough to handle my case.
> >> Tested moving SPI_CS_CNT_MAX to 16 and it was ok.

> > OK, I've also heard 12 as a number which this would cover.

> By the way the comment in include/linux/spi/spi.h is confusing. This
> SPI_CS_CNT_MAX is really not the max number of CS supported per SPI
> device but the max number of CS supported per SPI controller.

Well, it's a combination of the comment being confusing and the
implementation being a bit broken - we simply shouldn't be limiting the
number of chip selects per controller, the per device limit is much more
reasonable. So ideally the code would be changed to reflect the
comment.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2024-05-27 14:29    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog