Messages in this thread | | | Subject | Re: [PATCH net v2] vlan: skip nested type that is not IFLA_VLAN_QOS_MAPPING | From | patchwork-bot+netdevbpf@kernel ... | Date | Sat, 20 Jan 2024 05:30:27 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>:
On Thu, 18 Jan 2024 21:03:06 +0800 you wrote: > In the vlan_changelink function, a loop is used to parse the nested > attributes IFLA_VLAN_EGRESS_QOS and IFLA_VLAN_INGRESS_QOS in order to > obtain the struct ifla_vlan_qos_mapping. These two nested attributes are > checked in the vlan_validate_qos_map function, which calls > nla_validate_nested_deprecated with the vlan_map_policy. > > However, this deprecated validator applies a LIBERAL strictness, allowing > the presence of an attribute with the type IFLA_VLAN_QOS_UNSPEC. > Consequently, the loop in vlan_changelink may parse an attribute of type > IFLA_VLAN_QOS_UNSPEC and believe it carries a payload of > struct ifla_vlan_qos_mapping, which is not necessarily true. > > [...]
Here is the summary with links: - [net,v2] vlan: skip nested type that is not IFLA_VLAN_QOS_MAPPING https://git.kernel.org/netdev/net/c/6c21660fe221
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |