Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 02 Jan 2024 23:13:58 +0100 | From | Eric Woudstra <> | Subject | Re: [PATCH RFC net-next] net: pcs: pcs-mtk-lyn xi fix mtk pcs lynxi get state() for 2500base-x |
| |
I believe the general idea is that phylink should be aware wether to use inband or outband negotiation in order to setup the hardware correctly. Speaking of a situation where there is a PHY attached.
On January 2, 2024 9:01:23 PM GMT+01:00, Daniel Golle <daniel@makrotopia.org> wrote: >On Tue, Jan 02, 2024 at 08:33:32PM +0100, Eric Woudstra wrote: >> [...] >> >> So if phylink_mii_c22_pcs_decode_state() should not set the speed, then it is not correctly set somewhere else. > >Yes, but the fix should go to pcs-mtk-lynxi.c and you don't need to >change phylink for it to work. >This should be enough: >https://patchwork.kernel.org/project/netdevbpf/patch/091e466912f1333bb76d23e95dc6019c9b71645f.1699565880.git.daniel@makrotopia.org/ >
| ![\](/images/icornerr.gif) |