Messages in this thread | ![/](/images/icornerl.gif) | | From | Shakeel Butt <> | Date | Tue, 2 Jan 2024 13:54:17 -0800 | Subject | Re: [RFC PATCH net-next v4 1/2] net: introduce abstraction for network memory |
| |
On Tue, Jan 2, 2024 at 1:27 PM Mina Almasry <almasrymina@google.com> wrote: > > Add the netmem_ref type, an abstraction for network memory. > > To add support for new memory types to the net stack, we must first > abstract the current memory type. Currently parts of the net stack > use struct page directly: > > - page_pool > - drivers > - skb_frag_t > > Originally the plan was to reuse struct page* for the new memory types, > and to set the LSB on the page* to indicate it's not really a page. > However, for compiler type checking we need to introduce a new type. > > netmem_ref is introduced to abstract the underlying memory type. Currently > it's a no-op abstraction that is always a struct page underneath. In > parallel there is an undergoing effort to add support for devmem to the > net stack: > > https://lore.kernel.org/netdev/20231208005250.2910004-1-almasrymina@google.com/ > > Signed-off-by: Mina Almasry <almasrymina@google.com> >
I think you forgot to update the commit message to replace netmem_ref with netmem. Also you can mention that you took the approach similar to 'struct encoded_page'. Otherwise LGTM.
Reviewed-by: Shakeel Butt <shakeelb@google.com>
| ![\](/images/icornerr.gif) |