lkml.org 
[lkml]   [2024]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/6] accel/habanalabs: check failure of eventfd_signal
Date
From: Dafna Hirschfeld <dhirschfeld@habana.ai>

print err log if eventfd_signal return val is not 1 as expected.

Signed-off-by: Dafna Hirschfeld <dhirschfeld@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
---
drivers/accel/habanalabs/common/device.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c
index a365791a9f5c..e81ccafddfb3 100644
--- a/drivers/accel/habanalabs/common/device.c
+++ b/drivers/accel/habanalabs/common/device.c
@@ -2043,13 +2043,19 @@ int hl_device_cond_reset(struct hl_device *hdev, u32 flags, u64 event_mask)
return hl_device_reset(hdev, flags | HL_DRV_RESET_HARD);
}

-static void hl_notifier_event_send(struct hl_notifier_event *notifier_event, u64 event_mask)
+static void hl_notifier_event_send(struct hl_device *hdev,
+ struct hl_notifier_event *notifier_event, u64 event_mask)
{
+ u64 n;
+
mutex_lock(&notifier_event->lock);
notifier_event->events_mask |= event_mask;

- if (notifier_event->eventfd)
- eventfd_signal(notifier_event->eventfd, 1);
+ if (notifier_event->eventfd) {
+ n = eventfd_signal(notifier_event->eventfd, 1);
+ if (n != 1)
+ dev_err(hdev->dev, "eventfd signal failed, incremented by %llu\n", n);
+ }

mutex_unlock(&notifier_event->lock);
}
@@ -2073,7 +2079,7 @@ void hl_notifier_event_send_all(struct hl_device *hdev, u64 event_mask)
mutex_lock(&hdev->fpriv_list_lock);

list_for_each_entry(hpriv, &hdev->fpriv_list, dev_node)
- hl_notifier_event_send(&hpriv->notifier_event, event_mask);
+ hl_notifier_event_send(hdev, &hpriv->notifier_event, event_mask);

mutex_unlock(&hdev->fpriv_list_lock);
}
--
2.34.1

\
 
 \ /
  Last update: 2024-01-02 16:07    [W:0.027 / U:1.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site