Messages in this thread | | | Date | Tue, 02 Jan 2024 15:57:47 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs for a HP ZBook |
| |
On Tue, 02 Jan 2024 08:45:07 +0100, Geraldo Nascimento wrote: > > On Tue, Jan 02, 2024 at 02:59:56PM +0800, Andy Chi wrote: > > On Tue, Jan 2, 2024 at 2:42 PM Geraldo Nascimento > > <geraldogabriel@gmail.com> wrote: > > > > > > On Tue, Jan 02, 2024 at 01:49:40PM +0800, Andy Chi wrote: > > > > Hi Geraldo, > > > > Yes, this model is not yet publicly available, so I can't type the > > > > full name on this patch. > > > > > > > > (change to text plain mode to send out again.) > > > > > Hi Geraldo, > > > Hi Andy, please be kind and next time refrain from top-posting, > > > as it reverses the attention order for those reading the > > > discussion for posterity. > > > > > Got it, appreciate your feedback. > > > I think it is reasonable to mention it explicitly as an > > > upcoming product in order not to cause any confusion and > > > to make sure there's another janitorial patch later on > > > filling in the model details. > > > > > Should I mention it in the commit message? Or is it ok if I put the > > model name after it's on the market? > > Andy, in order to clear up any confusion that might arise later on, and > to maintain high the quality of both code and git meta-information I think > you should explicitly mention both in the commit info and commit message > that this is an upcoming product. > > Also, instead of just "HP" in the commit proper, it should say something > like "Upcoming HP ZBook". > > But that's just my advice, now you need to wait and hear Takashi's advice. > > We should always strive toward striking a healthy balance between companies' > needs and the public nature of the development of the Linux kernel and ALSA. > Unfortunately that means some details of upcoming models may end up > catching up the attention of the specialized press. > > I encourage you to look on the bright side and think of it as free PR ;)
I merged as is now with some comments about the new model. It's fine with the current patch if the entry will be updated later with a proper model name; having the code fix before the name definition would be more important.
thanks,
Takashi
| |