lkml.org 
[lkml]   [2024]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC net-next] ne t: phylink: add quirk for d isabling in-band-status for mediatek pcs at 2500base-x
    Sorry,  I'm on Android for now and have trouble find a suitable cliënt. This should have no http.


    Anyway, I see now, I had another version which I should have send:


    +       if (phylink_major_no_inband(pl, state->interface) && (!!pl->phydev)) {
    +               if (pl->cur_link_an_mode == MLO_AN_INBAND)
    +                       pl->cur_link_an_mode = MLO_AN_PHY;
    +       }
    +       else
    +              /* restore mode if it was changed before */
    +              pl->cur_link_an_mode = pl->cfg_link_an_mode;



    To prevent it from toggling all the time. So I do need to spend some more
    attention to this part, cause this also may not be 100% ok, if changing 
    phylink core would be done.




    The reason I do it in phylink, because of changing to MLO_AN_PHY when
    there is a PHY attached. mtk_eth_soc would not. Be aware of PHY attached.

    So that's why I've opened the rfc.

    See which way to go with this in an acceptable way, preferably using MLO_AN_PHY.


    \
     
     \ /
      Last update: 2024-01-02 13:32    [W:5.273 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site