Messages in this thread | | | From | Ricardo Ribalda <> | Date | Tue, 2 Jan 2024 12:31:53 +0100 | Subject | Re: [PATCH v2] usb: core: Add quirk for Logitech Rallybar |
| |
Hi Alan
On Sat, 23 Dec 2023 at 21:01, Alan Stern <stern@rowland.harvard.edu> wrote: > > On Fri, Dec 22, 2023 at 10:55:49PM +0000, Ricardo Ribalda wrote: > > Logitech Rallybar devices, despite behaving as UVC camera, they have a > > different power management system than the rest of the other Logitech > > cameras. > > > > USB_QUIRK_RESET_RESUME causes undesired USB disconnects, that make the > > device unusable. > > > > These are the only two devices that have this behavior, and we do not > > have the list of devices that require USB_QUIRK_RESET_RESUME, so lets > > create a new lit for them that un-apply the USB_QUIRK_RESET_RESUME > > quirk. > > > > Fixes: e387ef5c47dd ("usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams") > > Cc: stable@vger.kernel.org > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > > --- > > Would it make more sense to do this inside the uvc driver instead of > creating a new single-purpose list in the core?
I can try to move it to the uvc driver. But maybe it is better to keep it here:
The same vid:pid also has other functionality, not only uvc: Sync agent interface, UPD Interface, ADB interface. If we apply the quirk to the uvc driver, and the uvc driver is not loaded, the other functionality will still be broken....
I expect to see more devices from Logitech not needing the RESET_RESUME quirk... so this list will eventually grow.
Setting/useting RESET_RESUME in two different locations, can make the code difficult to follow.
What do you think?
Regards!
| |