lkml.org 
[lkml]   [2024]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] net/iucv: Improve unlocking in iucv_enable()
From
> @@ -555,13 +555,16 @@ static int iucv_enable(void)
>> if (cpumask_empty(&iucv_buffer_cpumask))
>> /* No cpu could declare an iucv buffer. */
>> goto out;
>> +
>> + rc = 0;
>> +unlock:
>> cpus_read_unlock();
>> - return 0;
>> + return rc;
>> +
>> out:
>> kfree(iucv_path_table);
>> iucv_path_table = NULL;
>> - cpus_read_unlock();
>> - return rc;
>> + goto unlock;
> [Suman] This looks confusing. What is the issue with retaining the original change?

I propose to reduce the number of cpus_read_unlock() calls
(in the source code).

Regards,
Markus

\
 
 \ /
  Last update: 2024-01-02 08:40    [W:0.050 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site